Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for consistent naming convention for MC simulation points / hits #319

Open
mfasDa opened this issue Apr 7, 2017 · 0 comments
Open

Comments

@mfasDa
Copy link
Collaborator

mfasDa commented Apr 7, 2017

I propose a consistent naming convention for MC simulation points / hits among detectors. Having consistent naming conventions improves the readability of the code. Since now AliceO2 has its own base class BasicHit I propose to use the name "Hit" as class name for detector hit classes. The name "Point" as class name for detector hit classes is in my opinion too general and might be even confusing as we might have different usages of Point objects in the future.

mfasDa added a commit to mfasDa/AliceO2 that referenced this issue Apr 10, 2017
Changing name of the MC hit class for EMCAL from point
to hit according to AliceO2Group#319
sawenzel pushed a commit that referenced this issue Apr 10, 2017
Changing name of the MC hit class for EMCAL from point
to hit according to #319
mikesas pushed a commit to mikesas/AliceO2 that referenced this issue Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant