Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-time testing macros in the interpreted mode #1351

Open
shahor02 opened this issue Sep 24, 2018 · 1 comment
Open

Build-time testing macros in the interpreted mode #1351

shahor02 opened this issue Sep 24, 2018 · 1 comment

Comments

@shahor02
Copy link
Collaborator

Hi,

In different PRs build tests we have some root -n -b -l -q -e ".L ${MACRO_FILE}" checks failing.
Digging with @sawenzel we saw that this happens due to some included classes not having dictionaries, e.g. those in the DataFormats/Headers/include/Headers, DPL etc. Since these are templated classes, obligatory creation of dictionaries for them would be too complicated.
Should we instead change the macro's check to a compiled mode in O2/Makefile, as
root -n -b -l -q -e ".L ${MACRO_FILE}+" ?

Cheers,
Ruben

@ktf
Copy link
Member

ktf commented Oct 4, 2018

For DPL my goal would be to remove any of those, so that ROOT can parse the header just fine. I am not there yet, but that's on the medium term plan. This is of course orthogonal to running the macros in compiled mode.

mikesas pushed a commit to mikesas/AliceO2 that referenced this issue Dec 13, 2022
…ceO2Group#1351)

* Fix for Mac not accepting not override marked overriding methods

* Update SelectionFilterAndAnalysis.cxx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants