Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS detection fails in packaged/production builds, causing undefined instead of menu icons #244

Open
mikeseese opened this issue Oct 12, 2023 · 0 comments

Comments

@mikeseese
Copy link
Contributor

mikeseese commented Oct 12, 2023

Problem Description

After packaging my Electron app for production, the min/max/close buttons show as undefined due to

Steps to Reproduce

  1. Integrate custom-electron-titlebar into https://github.com/electron-react-boilerplate/electron-react-boilerplate
  2. Run npm run package
  3. Run the installer in the release/build directory
  4. Installed app should have the noticed issues

Expected Behavior

The icons should display correctly.

Current Behavior

image

Additional Information

This is running on Windows 11.

Tentative Solution Steps

This seems to be due to incorrect OS detection in src/base/common/platform.ts. I was able to resolve this issue myself with this commit: Incanta@ba16f79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant