Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate get_access for target::host_buffer #973

Open
dnhsieh-intel opened this issue Mar 13, 2023 · 2 comments · May be fixed by #979
Open

Deprecate get_access for target::host_buffer #973

dnhsieh-intel opened this issue Mar 13, 2023 · 2 comments · May be fixed by #979
Labels
enhancement New feature or request

Comments

@dnhsieh-intel
Copy link

get_access for target::host_buffer has been deprecated in SYCL 2020. Please consider explicitly marking them as deprecated and suggest get_host_access() instead.

https://github.com/OpenSYCL/OpenSYCL/blob/d461988fe36b0a1db22dedce6916e77d268d1cfb/include/hipSYCL/sycl/buffer.hpp#L658-L664

https://github.com/OpenSYCL/OpenSYCL/blob/d461988fe36b0a1db22dedce6916e77d268d1cfb/include/hipSYCL/sycl/buffer.hpp#L682-L690
@dnhsieh-intel dnhsieh-intel added the enhancement New feature or request label Mar 13, 2023
@illuhad
Copy link
Collaborator

illuhad commented Mar 13, 2023

I agree, do you want to file a PR? :-)

@dnhsieh-intel
Copy link
Author

I can do it this weekend, but feel free to open a PR if someone is available sooner.

This was referenced Mar 13, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark get_access for target::host_buffer as deprecated dnhsieh-intel/OpenSYCL
2 participants
@illuhad @dnhsieh-intel