We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug summary
platform.get_info<sycl::info::platform::version>() (and hipsycl::sycl::detail::version_string) report version AdaptiveCpp 24.2.0+abcd instead of AdaptiveCpp 24.02.0+abcd.
platform.get_info<sycl::info::platform::version>()
hipsycl::sycl::detail::version_string
AdaptiveCpp 24.2.0+abcd
AdaptiveCpp 24.02.0+abcd
To Reproduce
$ acpp --acpp-version | grep 'AdaptiveCpp version' AdaptiveCpp version: 24.02.0+git.0359cac9.20240401.branch.develop.dirty $ cat test.cpp #include <iostream> #include <sycl/sycl.hpp> int main() { std::cout << hipsycl::sycl::detail::version_string() << std::endl; sycl::platform p; std::cout << p.get_info<sycl::info::platform::version>() << std::endl; } $ acpp -O2 test.cpp && ./a.out AdaptiveCpp 24.2.0+git.0359cac9.20240401.branch.develop.dirty AdaptiveCpp 24.2.0+git.0359cac9.20240401.branch.develop.dirty
Expected behavior
AdaptiveCpp 24.02.0+git.0359cac9.20240401.branch.develop.dirty is returned in both cases.
AdaptiveCpp 24.02.0+git.0359cac9.20240401.branch.develop.dirty
Describe your setup
Additional context
Nothing major or critical, just slightly annoying to have a discrepancy in reported versions.
The text was updated successfully, but these errors were encountered:
This is probably because the ACPP_VERISON_* macros are ints, which makes sense for the purpose of programmatically comparing version numbers. We'd have to enforce leading zeros in the version string formatting here: https://github.com/AdaptiveCpp/AdaptiveCpp/blob/develop/include/hipSYCL/sycl/version.hpp
ACPP_VERISON_*
Sorry, something went wrong.
Yes, looks like that. And BTW, the year in acpp --acpp-version | grep Copyright is out-of-date too.
acpp --acpp-version | grep Copyright
Shall this get a "good first issue" label? I don't think there's any rush in solving it before the late June? :)
No branches or pull requests
Bug summary
platform.get_info<sycl::info::platform::version>()
(andhipsycl::sycl::detail::version_string
) report versionAdaptiveCpp 24.2.0+abcd
instead ofAdaptiveCpp 24.02.0+abcd
.To Reproduce
Expected behavior
AdaptiveCpp 24.02.0+git.0359cac9.20240401.branch.develop.dirty
is returned in both cases.Describe your setup
Additional context
Nothing major or critical, just slightly annoying to have a discrepancy in reported versions.
The text was updated successfully, but these errors were encountered: