Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing constexpr for sycl::vec #1189

Open
aelizaro opened this issue Oct 16, 2023 · 4 comments · May be fixed by #1234
Open

Missing constexpr for sycl::vec #1189

aelizaro opened this issue Oct 16, 2023 · 4 comments · May be fixed by #1234
Assignees
@nilsfriess
Labels
bug Something isn't working

Comments

@aelizaro
Copy link

Bug summary
According to the latest sycl spec sycl::vec has constexpr constructors: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:vector.type Implementation is missing constexpr:

AdaptiveCpp/include/hipSYCL/sycl/libkernel/vec.hpp

Line 305 in f577603

HIPSYCL_UNIVERSAL_TARGET vec(const Args &...args) {

To Reproduce
Try to compile constexpr sycl::vec<int, 3> vec = {1, 2, 3};

Expected behavior
sycl::vec should have constexpr constructor - no compiler errors for the expression above.
@aelizaro aelizaro added the bug Something isn't working label Oct 16, 2023
@illuhad
Copy link
Collaborator

illuhad commented Oct 17, 2023

Thanks for reporting. For triaging, is there any particular use case that this is blocking?

@DieGoldeneEnte @nilsfriess, wasn't there some work already done somewhere that addresses this?

@aelizaro
Copy link
Author

Hi @illuhad, thank you for the reply, it is not a high priority as it can have a work-around, just a general alignment with sycl 2020.

Another place for example: sycl::accessor<...>::get_multi_ptr method

@nilsfriess
Copy link
Collaborator

I think we only did it for marray. But this should require similar changes, I‘ll have a look.

@nilsfriess nilsfriess self-assigned this Oct 18, 2023
@fodinabor
Copy link
Collaborator

https://github.com/AdaptiveCpp/AdaptiveCpp/pull/778/files
Was looked at for known identity iirc

@nilsfriess nilsfriess linked a pull request Nov 8, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilsfriess nilsfriess

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL2020] Make vec class constexpr-constructible nilsfriess/OpenSYCL
4 participants
@fodinabor @illuhad @nilsfriess @aelizaro