We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In computing the eigensystem of the MHD equations in mhd_eigen.H, we have logic like:
mhd_eigen.H
if (std::abs(cfz-csz) <= 1e-14){ alf = 1.0_rt; als = 0.0_rt; } if (as - csz < 0.0) { alf = 0.0_rt; } else { alf = std::sqrt((as - csz)/(cfz - csz)); } if (cfz - as < 0.0) { als = 0.0_rt; } else { als = std::sqrt((cfz - as)/(cfz - csz)); }
So the values set in the first test are never used, since they are overwritten by the else in the next 2 tests.
else
This was identified by clang-tidy
clang-tidy
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In computing the eigensystem of the MHD equations in
mhd_eigen.H
, we have logic like:So the values set in the first test are never used, since they are overwritten by the
else
in the next 2 tests.This was identified by
clang-tidy
The text was updated successfully, but these errors were encountered: