Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert scripts in developer/bin to Homebrew commands #174192

Open
1 of 22 tasks
bevanjkay opened this issue May 17, 2024 · 4 comments
Open
1 of 22 tasks

Convert scripts in developer/bin to Homebrew commands #174192

bevanjkay opened this issue May 17, 2024 · 4 comments

Comments

@bevanjkay
Copy link
Member

bevanjkay commented May 17, 2024

This is a proposal for how deal with the scripts in developer/bin.
Below is what I think we can keep / remove.

Migrate to a Homebrew Command

  • casks-without-zap
  • find-appcast
  • generate_cask_token
  • list_recent_pkg_ids (potentially combine with list_pkg_ids_by_regexp command with arguments)
  • list_pkg_ids_by_regexp
  • list_loaded_launchjob_ids (potentially combine with list_installed_launchjob_ids command with arguments)
  • list_installed_launchjob_ids
  • list_running_app_ids
  • list_id_in_kext
  • list_ids_in_app
  • list_ids_in_pkg (potentially combine into list-in-pkg with arguments)
  • list_payload_in_pkg (potentially combine into list-in-pkg with arguments)
  • list_apps_in_pkg (potentially combine into list-in-pkg with arguments)
  • list_loaded_kext_ids
  • list_login_items_for_app

Potentially Remove

  • list_url_attributes_on_file
  • update_cask_family
  • update_multilangual_casks
  • cask-pr-local-check
  • cask-pr-inspect-download

Requires Python for Protobuf handling so may be complicated to convert to Ruby

  • import_google_fonts

Re-add font_casker script from homebrew-cask-fonts

@bevanjkay
Copy link
Member Author

@Homebrew/cask
Interested in some feedback here to see what is used often.

I am not sure how many of the helpers we need to keep for building casks, as it seems most "ids" and "loaded items" are discovered on CI anyway, which I personally don't have a problem with.

@p-linnane
Copy link
Member

@Bo98 advised that we can probably use https://github.com/mrkn/pycall.rb for the fonts one.

@Bo98
Copy link
Member

Bo98 commented May 18, 2024

Is the proposal to move them to $(brew --repo homebrew/cask)/cmd (like homebrew-core's rebottle command)? If so: makes sense.

Some of the more generic ones that would be useful for third-party cask taps could be in Homebrew/brew, with modifications. For example, integrating scripts like generate_cask_token into brew create (and/or an audit) probably makes sense.

@bevanjkay
Copy link
Member Author

Is the proposal to move them to $(brew --repo homebrew/cask)/cmd (like homebrew-core's rebottle command)? If so: makes sense.

Yeah, this exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants